Skip to content

Fixed wrong statement regarding data rate. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

hkayann
Copy link
Contributor

@hkayann hkayann commented Nov 15, 2021

I do not know, why data rate is mentioned as 104 Hz. I believe it is just a simple mistake.

It led me thinking that I was getting duplicate values, as I was getting more than 104 values per second.

@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: documentation Related to documentation for the project labels Nov 21, 2021
@aentinger
Copy link
Contributor

I've just checked. The output data rate is configured here. The LSM9DS1 datasheet says on page 46/72, that

ODR_G [2:0] BW_G [1:0] ODR [Hz] Cutoff [Hz]
011 00 119 14

So 119 Hz seems to be in fact correct.

@aentinger aentinger closed this Jun 30, 2022
@per1234 per1234 added the conclusion: invalid Issue/PR not valid label Jun 30, 2022
@per1234
Copy link
Contributor

per1234 commented Jun 30, 2022

119 Hz seems to be in fact correct.

@aentinger this pull request is proposing to change the current claim in the documentation that it is 104 Hz:

- Accelerometer and gyrospcope output data rate is fixed at 104 Hz.

So if 119 Hz is correct then this should be merged instead of closed. Please take another look when you get a chance.

@hkayann
Copy link
Contributor Author

hkayann commented Jun 30, 2022

Hi @per1234,

Yes that is the case, I think @aentinger just misunderstood.

@aentinger aentinger reopened this Jun 30, 2022
@aentinger
Copy link
Contributor

God, I think I need a ☕ 🤦

@aentinger aentinger merged commit 42f0656 into arduino-libraries:master Jun 30, 2022
@per1234 per1234 removed the conclusion: invalid Issue/PR not valid label Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants